Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare frontend group dependency & use explicit dependencies in launch_testing #520

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Declare frontend group dependency & use explicit dependencies in launch_testing #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58ef076
Switch to package format 3
christophebedard Jul 15, 2021
19786bf
Declare dependency on launch_{xml,yaml} in launch_testing
christophebedard Jul 15, 2021
8966192
Declare a 'launch_frontend_packages' group and use in launch_testing
christophebedard Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions launch_testing/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="2">
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>launch_testing</name>
<version>0.19.0</version>
<description>A package to create tests which involve launch files and multiple processes.</description>
Expand All @@ -15,6 +15,9 @@

<exec_depend>ament_index_python</exec_depend>
<exec_depend>launch</exec_depend>
<!-- explicitly depend on the main launch frontends -->
<exec_depend>launch_xml</exec_depend>
<exec_depend>launch_yaml</exec_depend>
<exec_depend>osrf_pycommon</exec_depend>
<exec_depend>python3-pytest</exec_depend>

Expand All @@ -23,6 +26,8 @@
<test_depend>ament_pep257</test_depend>
<test_depend>launch</test_depend>

<group_depend>launch_frontend_packages</group_depend>

<export>
<build_type>ament_python</build_type>
</export>
Expand Down
6 changes: 4 additions & 2 deletions launch_xml/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="2">
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>launch_xml</name>
<version>0.19.0</version>
<description>XML frontend for the launch package.</description>
Expand All @@ -18,6 +18,8 @@
<test_depend>ament_pep257</test_depend>
<test_depend>python3-pytest</test_depend>

<member_of_group>launch_frontend_packages</member_of_group>

<export>
<build_type>ament_python</build_type>
</export>
Expand Down
6 changes: 4 additions & 2 deletions launch_yaml/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="2">
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>launch_yaml</name>
<version>0.19.0</version>
<description>YAML frontend for the launch package.</description>
Expand All @@ -18,6 +18,8 @@
<test_depend>ament_pep257</test_depend>
<test_depend>python3-pytest</test_depend>

<member_of_group>launch_frontend_packages</member_of_group>

<export>
<build_type>ament_python</build_type>
</export>
Expand Down