Declare frontend group dependency & use explicit dependencies in launch_testing #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophebedard
force-pushed
the
launch-frontend-dependencies
branch
from
87d3807 to
a00eae9
Compare
Signed-off-by: Christophe Bedard <[email protected]>
Signed-off-by: Christophe Bedard <[email protected]>
Signed-off-by: Christophe Bedard <[email protected]>
christophebedard
force-pushed
the
launch-frontend-dependencies
branch
from
a00eae9 to
8966192
Compare
|
@wjwwood I think this can be merged. This PR was tested alongside ros2/launch_ros#256, see ros2/launch_ros#256 (comment) |
jacobperron
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ros2/launch_ros#255
As suggested/discussed under #516 (comment), this declares a group dependency for the launch frontends and declares explicit dependencies on
launch_xmlandlaunch_yamlforlaunch_testing.Using both a group dependency and hard/explicit dependencies allows this to work fine with binaries (with bloom) and also allows us to include any future launch frontend (or any user's custom frontend) in source builds. This is similar to how
rcldepends on both thercl_logging_packagesgroup and the default logging implementation explicitly.Signed-off-by: Christophe Bedard [email protected]