Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(launch) fix describe of PathJoinSubstitution #771

Merged
merged 1 commit into from
Apr 11, 2024
Merged

(launch) fix describe of PathJoinSubstitution #771

merged 1 commit into from
Apr 11, 2024

Conversation

MatthijsBurgh
Copy link
Contributor

No description provided.

@MatthijsBurgh
Copy link
Contributor Author

CI Issues are related to https://bugs.launchpad.net/ubuntu/+source/python-flake8/+bug/2012523

clalancette
clalancette approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. I'm going to run full CI on this, just to make sure nothing is depending on the "old" behavior (even though it is wrong).

@clalancette
Copy link
Contributor

clalancette commented Apr 10, 2024 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit f8f25b8 into ros2:rolling Apr 11, 2024
2 of 3 checks passed
@MatthijsBurgh MatthijsBurgh deleted the patch-2 branch April 12, 2024 09:04
@MatthijsBurgh MatthijsBurgh mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

@methylDragon methylDragon Awaiting requested review from methylDragon

@wjwwood wjwwood Awaiting requested review from wjwwood

Assignees

@wjwwood wjwwood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatthijsBurgh @clalancette @wjwwood