Avoid priority inversions in rclcpp #2078
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Mayer <[email protected]>
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/avoiding-priority-inversions-includes-draft-pull-requests/29219/1 |
|
A ROS Discourse article has been created for this pull request: |
WideAwakeTN
requested review from
ivanpauno,
hidmic and
wjwwood
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content of this pull request ensures that threads in rclcpp will not experience priority inversions when using hard realtime scheduling, i.e. FIFO scheduling as defined in the POSIX standard. This is achieved by replacing std::mutex with rclcpp::PIMutex and std::recursive_mutex with rclcpp::RecursivePIMutex. To compile this pull request the following pull requests for rcutils and rcpputils are required:
ros2/rcpputils#174
ros2/rcutils#406
The code changes in this pull request should not effect the runtime behavior of existing ROS2 projects in a negative way. In case that a project uses ordinary fair/non-realtime thread scheduling it should behave as before.
In case this pull request gets accepted other ROS2 components can be made priority inversion safe in the manner which was demonstrated here. Refactoring all relevant ROS2 core components will make ROS2 more suitable for hard realtime scenarios.