Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycle node dtor shutdown should be called only in primary state. #2543

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

fujitatomoya
Copy link
Collaborator

cherry-pick a3caf17

@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

please do not merge this yet, i think we need to add #2545.

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/bp/iron/pr-2528 branch from 09ef30e to fefa0cc Compare May 30, 2024 22:49
@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

windows failure is unrelated.

@fujitatomoya fujitatomoya merged commit dceb612 into iron Jun 6, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fujitatomoya/bp/iron/pr-2528 branch June 6, 2024 18:05
fujitatomoya added a commit that referenced this pull request Jun 10, 2024
… state. (#2543)"

This reverts commit dceb612.

Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya added a commit that referenced this pull request Jun 11, 2024
* Revert "lifecycle node dtor shutdown should be called only in primary state. (#2543)"

This reverts commit dceb612.

Signed-off-by: Tomoya Fujita <[email protected]>

* Revert "call shutdown in LifecycleNode dtor to avoid leaving the device in un… (#2450) (#2490)"

This reverts commit f41a353.

Signed-off-by: Tomoya Fujita <[email protected]>

---------

Signed-off-by: Tomoya Fujita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant