This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Groundwork for one participant per context refactor #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
…://github.com/ros2/rmw_connext into ivanpauno/prepare-one-participant-per-context
ivanpauno
added
enhancement
hidmic
reviewed
Jan 7, 2020
| ConnextPublisherListener * publisher_listener = nullptr; | ||
| ConnextStaticPublisherInfo * publisher_info = nullptr; | ||
| rmw_publisher_t * publisher = nullptr; | ||
| std::string mangled_name = ""; |
There was a problem hiding this comment.
@ivanpauno nit: no need to initialize with an empty string.
There was a problem hiding this comment.
I actually copy-pasted that, but ok.
rmw_connext_cpp/src/rmw_service.cpp
Outdated
| @@ -56,7 +56,7 @@ rmw_create_service( | |||
| return nullptr; | |||
| } | |||
|
|
|||
| auto node_info = static_cast<ConnextNodeInfo *>(node->data); | |||
| auto node_info = static_cast<ConnextParticipantInfo *>(node->data); | |||
There was a problem hiding this comment.
@ivanpauno here and elsewhere, ConnextNodeInfo became ConnextParticipantInfo, but I don't see the struct defined and node_info is probably not the right name anymore.
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
|
Closing as this is not going to be continued (considering that https://github.com/rticommunity/rmw_connextdds already implemented this new approach). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groundwork for #381.
Just moving code around, shouldn't change behavior.
This allows to:
This refactor can be merged right now, avoiding hard rebases later.