Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the received timestamp #338

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

YuanYuYuan
Copy link
Contributor

@YuanYuYuan YuanYuYuan commented Dec 13, 2024

Closes #337. This timestamp should be the one when received rather than the one when sent.

ros2 topic echo /clock
clock:
  sec: 1734081513
  nanosec: 389786241
---
clock:
  sec: 1734081513
  nanosec: 414703983
---
clock:
  sec: 1734081513
  nanosec: 439739606
---

Copy link
Collaborator

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this one, and merge it, but I'll also have a follow-up PR since we need this in several other places as well.

@clalancette clalancette merged commit dd82e84 into ros2:rolling Dec 13, 2024
6 checks passed
@clalancette
Copy link
Collaborator

I'm going to approve this one, and merge it, but I'll also have a follow-up PR since we need this in several other places as well.

Oh no, never mind. That is only on the zenoh-cpp branch that we need this. This should be enough now; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clock topic in bag negative
3 participants