Inform users that peers will not discover and communicate with one another until the router is started #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…other until the router is started Signed-off-by: Yadunund <[email protected]>
Yadunund
force-pushed
the
yadu/emphasize_router_start
branch
from
cfaeb91 to
5a5e65e
Compare
ahcorde
approved these changes
Jan 30, 2025
Timple
reviewed
Jan 31, 2025
| "Have you started a router with `ros2 run rmw_zenoh_cpp rmw_zenohd`?"); | ||
| "Have you started a router with `ros2 run rmw_zenoh_cpp rmw_zenohd`? " | ||
| "You may also increase the number of attempts to check for a router " | ||
| "but setting the ZENOH_ROUTER_CHECK_ATTEMPTS environment variable."); |
Timple
reviewed
Jan 31, 2025
| @@ -108,9 +108,17 @@ class rmw_context_impl_s::Data final : public std::enable_shared_from_this<Data> | |||
| RMW_ZENOH_LOG_WARN_NAMED( | |||
| "rmw_zenoh_cpp", | |||
| "Unable to connect to a Zenoh router. " | |||
| "Have you started a router with `ros2 run rmw_zenoh_cpp rmw_zenohd`?"); | |||
| "Have you started a router with `ros2 run rmw_zenoh_cpp rmw_zenohd`? " | |||
| "You may also increase the number of attempts to check for a router " | |||
There was a problem hiding this comment.
I don't think this hint adds much. Playing with ZENOH_ROUTER_CHECK_ATTEMPTS is only useful if all checks are exhausted. And thus this hint would be better placed at the log below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address ambiguity from #439