Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform users that peers will not discover and communicate with one another until the router is started #440

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Inform users that peers will not discover and communicate with one another until the router is started #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion rmw_zenoh_cpp/src/detail/rmw_context_impl_s.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,17 @@ class rmw_context_impl_s::Data final : public std::enable_shared_from_this<Data>
RMW_ZENOH_LOG_WARN_NAMED(
"rmw_zenoh_cpp",
"Unable to connect to a Zenoh router. "
"Have you started a router with `ros2 run rmw_zenoh_cpp rmw_zenohd`?");
"Have you started a router with `ros2 run rmw_zenoh_cpp rmw_zenohd`? "
"You may also increase the number of attempts to check for a router "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this hint adds much. Playing with ZENOH_ROUTER_CHECK_ATTEMPTS is only useful if all checks are exhausted. And thus this hint would be better placed at the log below.

"but setting the ZENOH_ROUTER_CHECK_ATTEMPTS environment variable.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but -> by?

}
if (++connection_attempts >= configured_connection_attempts.value()) {
RMW_ZENOH_LOG_WARN_NAMED(
"rmw_zenoh_cpp",
"Unable to connect to a Zenoh router after %zu attempt(s). "
"Proceeding with initialization but other peers will not discover "
"or receive data from peers in this session until the router is started.",
configured_connection_attempts.value());
break;
}
std::this_thread::sleep_for(sleep_time);
Expand Down