Enables CI when pushing rolling branch. #82
Conversation
Signed-off-by: Franco Cipollone <[email protected]>
|
CI failing due to: eclipse-zenoh/zenoh-c#214 |
|
Retriggering CI after eclipse-zenoh/zenoh-c#214 is merged |
| @@ -2,7 +2,8 @@ name: build | |||
| on: | |||
| pull_request: | |||
| push: | |||
| branches: [ main ] | |||
| branches: [ rolling ] | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
Do we still need the workflow_dispatch key?
There was a problem hiding this comment.
As we are targeting master for the zenoh dependency I found it useful to be able to run it via workflow_dispatch to verify that everything works as expected when a new commit is pushed in zenoh-c .
There was a problem hiding this comment.
As we are targeting master for the zenoh dependency I found it useful to be able to run it via
workflow_dispatchto verify that everything works as expected when a new commit is pushed in zenoh-c .
I'm fine with it for now, though I expect very soon that we should pin the zenoh-c commit that we are using, and only update it when we need a new feature.
| @@ -2,7 +2,8 @@ name: build | |||
| on: | |||
| pull_request: | |||
| push: | |||
| branches: [ main ] | |||
| branches: [ rolling ] | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
As we are targeting master for the zenoh dependency I found it useful to be able to run it via
workflow_dispatchto verify that everything works as expected when a new commit is pushed in zenoh-c .
I'm fine with it for now, though I expect very soon that we should pin the zenoh-c commit that we are using, and only update it when we need a new feature.
delete-merged-branch
bot
deleted the
francocipollone/enable_ci_in_push
branch
Signed-off-by: Franco Cipollone <[email protected]>
I wanted to double-check check CI is passing after last zenoh-c commit and found this minor bug.
Summary