Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables CI when pushing rolling branch. #82

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Enables CI when pushing rolling branch. #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ name: build
on:
pull_request:
push:
branches: [ main ]
branches: [ rolling ]
workflow_dispatch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the workflow_dispatch key?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are targeting master for the zenoh dependency I found it useful to be able to run it via workflow_dispatch to verify that everything works as expected when a new commit is pushed in zenoh-c .

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are targeting master for the zenoh dependency I found it useful to be able to run it via workflow_dispatch to verify that everything works as expected when a new commit is pushed in zenoh-c .

I'm fine with it for now, though I expect very soon that we should pin the zenoh-c commit that we are using, and only update it when we need a new feature.

defaults:
run:
shell: bash
Expand Down
Loading