Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[humble backport] Added C interfaces to obtain service and action type support. #149

Merged
merged 1 commit into from
Aug 20, 2024
Merged

[humble backport] Added C interfaces to obtain service and action type support. #149

merged 1 commit into from
Aug 20, 2024

Conversation

StefanFabian
Copy link
Contributor

Backport of #143 for humble. See #114 for discussion.
Interfaces are declared in ros2/rosidl#778

@StefanFabian StefanFabian mentioned this pull request Dec 27, 2023
Merged
@StefanFabian StefanFabian mentioned this pull request Mar 13, 2024
Open
@StefanFabian StefanFabian mentioned this pull request Apr 4, 2024
Closed
@achim-k
Copy link

achim-k commented Apr 4, 2024

@clalancette can we consider merging this?

@matthews-jca
Copy link

This would be very helpful to have in Humble

@aaron-jca
Copy link

@sloretz @clalancette Is there anything preventing this from being merged in?

sloretz
sloretz approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@sloretz
Copy link
Contributor

sloretz commented Aug 9, 2024

Pulls: #149, ros2/rosidl#778
Gist: https://gist.githubusercontent.com/sloretz/0a0f8447f0dd31298d68c354caa495c8/raw/358b1dfadc3a1627a7282e0844713b6941185ef1/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_generator_cpp rosidl_typesupport_cpp
TEST args: --packages-above rosidl_generator_cpp rosidl_typesupport_cpp
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14398

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@sloretz sloretz mentioned this pull request Aug 9, 2024
Merged
@sloretz
Copy link
Contributor

sloretz commented Aug 20, 2024

Pulls: #149, ros2/rosidl#778
Gist: https://gist.githubusercontent.com/sloretz/06126274d7292096ce2288c10d7de10b/raw/358b1dfadc3a1627a7282e0844713b6941185ef1/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_generator_cpp rosidl_typesupport_cpp
TEST args: --packages-above rosidl_generator_cpp rosidl_typesupport_cpp
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14415

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@sloretz sloretz merged commit a702c17 into ros2:humble Aug 20, 2024
3 checks passed
@clalancette clalancette mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StefanFabian @achim-k @matthews-jca @aaron-jca @sloretz