API: Add LRO_USERNAME and LRO_PASSWORD options #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original LRO_USERPWD option does not support a colon in the username. Use LRO_USERNAME and LRO_PASSWORD instead. The description of the LRO_USERPWD option has been expanded: The user and password strings are not URL decoded, so there is no way to send in a username containing a colon using this option. The option is DEPRECATED! Use LRO_USERNAME and LRO_PASSWORD. The description of the LRO_PROXYUSERPWD option has been expanded: Both the username and the password are URL decoded before use, so if the username contains, for example, a colon, it should be encoded as %3A.
jrohel
force-pushed
the
LRO_USERNAME_and_LRO_PASSWORD
branch
from
f6a918f to
13281f8
Compare
This was referenced Jun 24, 2024
Merged
evan-goode
reviewed
Jun 27, 2024
| @@ -170,7 +173,9 @@ typedef enum { | |||
| Use LRO_PROXYAUTHMETHODS */ | |||
|
|
|||
| LRO_PROXYUSERPWD, /*!< (char *) | |||
| User and password for proxy in format user:password */ | |||
| User and password for proxy in format user:password | |||
| Both the username and the password are URL decoded before use, so if the username | |||
There was a problem hiding this comment.
Ah, I see, this was the behavior already, but good that it's more clearly documented now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
LRO_USERPWDoption does not support a colon in the username. UseLRO_USERNAMEandLRO_PASSWORDinstead.The description of the
LRO_USERPWDoption has been expanded:The user and password strings are not URL decoded, so there is no way to send in a username containing a colon using this option. The option is DEPRECATED!
Use LRO_USERNAME and LRO_PASSWORD.
The description of the
LRO_PROXYUSERPWDoption has been expanded:Both the username and the password are URL decoded before use, so if the username contains, for example, a colon, it should be encoded as %3A.
Unit tests for
LRO_USERNAMEandLRO_PASSWORDare included.Closes: #315