Convert values coming in from WalletConnect #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilanolkies
reviewed
Nov 30, 2021
ilanolkies
suggested changes
Dec 1, 2021
| to: payload.to, | ||
| from: payload.from, | ||
| nonce: payload.nonce, | ||
| data: payload.data || constants.HashZero, |
There was a problem hiding this comment.
We need 0x here as no data. HashZero produces 32 bytes
There was a problem hiding this comment.
I updated this to be 0x but I also made the default for gasPrice and gasLimit undefined. I think this adapter should not set them to zero in case it is reused in a different app. In #72, if the gasLimit/gasPrice are undefined, then it will use the estimates.
| @@ -23,6 +23,8 @@ describe('Wallet Connect Adapter', () => { | |||
| from, | |||
| to, | |||
| value: '0x3e8', | |||
| gas: '25000', | |||
There was a problem hiding this comment.
Should we add two tests? One for the payload with values and another for the defaults that trigger estimations
There was a problem hiding this comment.
I added a new test and refactored the existing test to use spyon to get the parameters being sent to sendTransaction.
- Spyon the sendTransaction method to get the parameters that are being sent to the provider - Change default values to undefined not zero.
ilanolkies
approved these changes
Dec 5, 2021
ilanolkies
added
tx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert values coming from WalletConnect to integers which is what is expected. Also, delete thegasproperty as this was also causing ethers to fail.This uses BigNumber'sfrommethod to handle the conversion to BigNumber then back to number. We could extract out thefromportion if it would make it faster.Update:
TransactionRequestincluding renaminggastogasLimit.notes