Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sciurus17_gazeboのROS 2対応 #140

Merged
merged 9 commits into from
Oct 16, 2023
Merged

sciurus17_gazeboのROS 2対応 #140

merged 9 commits into from
Oct 16, 2023

Conversation

Kuwamai
Copy link
Contributor

@Kuwamai Kuwamai commented Oct 13, 2023

What does this implement/fix?

sciurus17_gazeboのROS 2対応です。
controller、MoveIt等は未対応のため、Gazebo上でモデルの表示のみ行います。

Does this close any currently open issues?

How has this been tested?

表示するURDFは下記PRを参照してください
rt-net/sciurus17_description#5

下記コマンドでGazeboを起動し、モデルが表示されることを確認しました。

ros2 launch sciurus17_gazebo sciurus17_with_table.launch.py

Any other comments?

Checklists

@Kuwamai Kuwamai added the Type: Feature New Feature label Oct 13, 2023
@Kuwamai Kuwamai requested a review from ShotaAk October 13, 2023 03:44
@Kuwamai Kuwamai self-assigned this Oct 13, 2023
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

モデルの表示を確認しました。

Collisionの表示も確認しています。
Inertiaについては未確認です。ros2_control対応時に見てみます。

コメントしたので対応お願いします。

sciurus17_gazebo/worlds/table.sdf Outdated Show resolved Hide resolved
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShotaAk ShotaAk merged commit 1401779 into ros2 Oct 16, 2023
2 checks passed
@ShotaAk ShotaAk deleted the support_ros2_gazebo branch October 16, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants