Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Ruby version from Gemfile.lock #592

Closed

Conversation

benlangfeld
Copy link

Fixes #590

Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good but needs some tweaks

action.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
.ruby-version Outdated Show resolved Hide resolved
.tool-versions Outdated Show resolved Hide resolved
@eregon
Copy link
Member

eregon commented May 6, 2024

@benlangfeld Please take a look at #590 (comment), after more thoughts I'm not sure there is value in this feature, it seems one should use .ruby-version anyway to avoid duplication and ensure the right Ruby is picked by Ruby switchers.

@benlangfeld benlangfeld closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Ruby version should be read from Gemfile.lock by default
2 participants