-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: build for macOS #431
fix: build for macOS #431
Conversation
Pull Request Test Coverage Report for Build 9030421145Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@@ -21,7 +21,7 @@ bio-types = ">=0.9" | |||
byteorder = "1.3" | |||
custom_derive = "0.1" | |||
derive-new = "0.5" | |||
hts-sys = {version = "2.1.1", default-features = false} | |||
hts-sys = {version = "2.1.4", default-features = false, features = ["bindgen"]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this an intentional change that bindgen
changed from an optional dependency to a required dependency of rust-htslib
?
For getting the CI running on
aarch64-apple-darwin
runners hts-sys needs to be updated due to an issue caused by bindgen. This has been fixed in the latesthts-sys
release (see rust-bio/hts-sys#10).