Skip to content

fix: build for macOS #249

fix: build for macOS

fix: build for macOS #249

GitHub Actions / clippy failed May 10, 2024 in 0s

clippy

1 error, 1 warning

Details

Results

Message level Amount
Internal compiler error 0
Error 1
Warning 1
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check failure on line 260 in src/bgzf/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

mismatched types

error[E0308]: mismatched types
     --> src/bgzf/mod.rs:260:17
      |
257   |             htslib::bgzf_write(
      |             ------------------ arguments to this function are incorrect
...
260   |                 buf.len() as u64,
      |                 ^^^^^^^^^^^^^^^^ expected `usize`, found `u64`
      |
note: function defined here
     --> /home/runner/work/rust-htslib/rust-htslib/target/debug/build/hts-sys-54eaf746d411afb9/out/bindings.rs:10315:12
      |
10315 |     pub fn bgzf_write(fp: *mut BGZF, data: *const ::std::os::raw::c_void, length: usize) -> isize;
      |            ^^^^^^^^^^
help: you can convert a `u64` to a `usize` and panic if the converted value doesn't fit
      |
260   |                 (buf.len() as u64).try_into().unwrap(),
      |                 +                +++++++++++++++++++++

Check warning on line 1395 in src/bam/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary parentheses around function argument

warning: unnecessary parentheses around function argument
    --> src/bam/mod.rs:1395:45
     |
1395 |             let rec = htslib::sam_hdr_parse((l_text + 1), text as *const c_char);
     |                                             ^          ^
     |
     = note: `#[warn(unused_parens)]` on by default
help: remove these parentheses
     |
1395 -             let rec = htslib::sam_hdr_parse((l_text + 1), text as *const c_char);
1395 +             let rec = htslib::sam_hdr_parse(l_text + 1, text as *const c_char);
     |