upgrade to rust 2021 edition #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so far the crate used the default edition (2015). upgrading to the newest edition before having the first major release creates a stable platform on which to build in the future. the current edition is also already two years old, so it is likely that most consumers are already using a compatible rust version. for those which might not have upgraded it remains an option to use an existing release of the crate for the time being. setting [`rust-version`] allows having cleaner error messages for those using older rust compilers - though as of now this will not be particularly helpful as the field is only supported starting with rust 1.56 which is also the version introducing support for the 2021 edition. nevertheless, already specifying it now creates a base for future MSRV updates. note: all code changes were done by running `cargo fix --edition` as per the [upgrade guide]. [upgrade guide]: https://doc.rust-lang.org/edition-guide/editions/transitioning-an-existing-project-to-a-new-edition.html [`rust-version`]: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field
for details see [the clippy warning](https://rust-lang.github.io/rust-clippy/master/index.html#/ptr_offset_with_cast).
note that this is just a suggestion as a basis for discussion. some crates are doing this (updating with new patch release), others are much stricter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see the individual commit messages for details.
esp. the MSRV policy is just a suggestion - i can also drop that commit from this PR.