Use a bit less NonNull::new_unchecked #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This project's CI is broken due to a dependency on a previous version of itself. Well ain't that something. |
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Feb 12, 2024
Use a bit less NonNull::new_unchecked Using `NonNull::cast` instead of `NonNull::new_unchecked` is a bit less unsafe code, and it may provide a small improvement to compile times since rust-lang/rust#120594
|
💔 Test failed - checks-actions |
|
☔ The latest upstream changes (presumably #502) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I fixed the CI separately in #502, can you rebase? |
saethlin
force-pushed
the
less-unchecked
branch
from
46f1afc to
87d58ec
Compare
|
Rebased! |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
NonNull::castinstead ofNonNull::new_uncheckedis a bit less unsafe code, and it may provide a small improvement to compile times since rust-lang/rust#120594