Skip to content

Switch exploit mitigations to mdbook footnotes #140051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Apr 19, 2025

This updates the exploit mitigations chapter in the rustc book to use the footnote feature of mdbook instead of manually implementing footnotes with HTML.

This updates the exploit mitigations chapter in the rustc book to use
the footnote feature of mdbook instead of manually implementing
footnotes with HTML.
@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2025

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2025

Some changes occurred in src/doc/rustc/src/exploit-mitigations.md

cc @rust-lang/project-exploit-mitigations, @rcvalle

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

r? jieyouxu @bors r+ rollup

@rustbot rustbot assigned jieyouxu and unassigned BoxyUwU Apr 20, 2025
@bors
Copy link
Collaborator

bors commented Apr 20, 2025

📌 Commit f3b7e23 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2025
@jieyouxu

This comment has been minimized.

ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 20, 2025
Switch exploit mitigations to mdbook footnotes

This updates the exploit mitigations chapter in the rustc book to use the footnote feature of mdbook instead of manually implementing footnotes with HTML.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 20, 2025
…enton

Rollup of 3 pull requests

Successful merges:

 - rust-lang#139990 (transmutability: remove NFA intermediate representation)
 - rust-lang#140044 (rustc-dev-guide subtree update)
 - rust-lang#140051 (Switch exploit mitigations to mdbook footnotes)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 20, 2025
…enton

Rollup of 5 pull requests

Successful merges:

 - rust-lang#137953 (simd intrinsics with mask: accept unsigned integer masks, and fix some of the errors)
 - rust-lang#139990 (transmutability: remove NFA intermediate representation)
 - rust-lang#140044 (rustc-dev-guide subtree update)
 - rust-lang#140051 (Switch exploit mitigations to mdbook footnotes)
 - rust-lang#140054 (docs: fix typo change from inconstants to invariants)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 20, 2025
…enton

Rollup of 5 pull requests

Successful merges:

 - rust-lang#137953 (simd intrinsics with mask: accept unsigned integer masks, and fix some of the errors)
 - rust-lang#139990 (transmutability: remove NFA intermediate representation)
 - rust-lang#140044 (rustc-dev-guide subtree update)
 - rust-lang#140051 (Switch exploit mitigations to mdbook footnotes)
 - rust-lang#140054 (docs: fix typo change from inconstants to invariants)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 20, 2025
…enton

Rollup of 5 pull requests

Successful merges:

 - rust-lang#137953 (simd intrinsics with mask: accept unsigned integer masks, and fix some of the errors)
 - rust-lang#139990 (transmutability: remove NFA intermediate representation)
 - rust-lang#140044 (rustc-dev-guide subtree update)
 - rust-lang#140051 (Switch exploit mitigations to mdbook footnotes)
 - rust-lang#140054 (docs: fix typo change from inconstants to invariants)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c113a3b into rust-lang:master Apr 21, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 21, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2025
Rollup merge of rust-lang#140051 - ehuss:exploit-footnotes, r=jieyouxu

Switch exploit mitigations to mdbook footnotes

This updates the exploit mitigations chapter in the rustc book to use the footnote feature of mdbook instead of manually implementing footnotes with HTML.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants