-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ansi-term PR 80): Add "bright" builtin codes and tests. #12
Conversation
Wait what?!
|
gahh what is with this test failing.. I ran this PR locally and it passed all tests and didn't break eza... and i cant get any (useful) info from the output of the failed action. Lame. I'll figure it out. The CI looks fine on the other PR's is the problem |
I rebased it against the current main, maybe that'll change anything. |
ok, now both test and coverage jobs are failing XD ... that's not really an improvement but at least consistent :D |
ah wait now it fails locally, too |
interesting ... i think maybe due to the merge conflict or something maybe both workflows ran with different revisions. |
Ahhh, ok now I see the error ... there where some missing match cases ... for some reason the merge might have been incomplete and that's why it didn't show up in both workflow runs ... one was working with a different revision. weird!! :D |
Alright, now it should be ready for review and merging. That was certainly a weird issue. The test output referenced code not actually on the branch. No idea what exactly went wrong there. Must have been something with the merge conflict I had to resolve I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ok I thought i was hallucinating.. cuz none of that code was local on my machine. I did have to update the branch with the syntax fixes that I updated the main branch with to get it to pass tho. But either way, this doesn't break Eza |
ogham/rust-ansi-term#80