Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ansi-term PR 80): Add "bright" builtin codes and tests. #12

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

gierens
Copy link
Member

@gierens gierens commented Aug 29, 2023

@gierens
Copy link
Member Author

gierens commented Aug 29, 2023

Wait what?!

  1. we have duplicate tests, opened an issue for it Duplicate Github Workflows #13
  2. but more importantly why do the same tests fail in the pull_request tests fail but not the push tests?

@PThorpe92
Copy link
Member

gahh what is with this test failing.. I ran this PR locally and it passed all tests and didn't break eza... and i cant get any (useful) info from the output of the failed action. Lame. I'll figure it out. The CI looks fine on the other PR's is the problem

@gierens
Copy link
Member Author

gierens commented Aug 30, 2023

I rebased it against the current main, maybe that'll change anything.

@gierens
Copy link
Member Author

gierens commented Aug 30, 2023

ok, now both test and coverage jobs are failing XD ... that's not really an improvement but at least consistent :D

@gierens
Copy link
Member Author

gierens commented Aug 30, 2023

ah wait now it fails locally, too

@gierens
Copy link
Member Author

gierens commented Aug 30, 2023

interesting ... i think maybe due to the merge conflict or something maybe both workflows ran with different revisions.

@gierens
Copy link
Member Author

gierens commented Aug 30, 2023

Ahhh, ok now I see the error ... there where some missing match cases ... for some reason the merge might have been incomplete and that's why it didn't show up in both workflow runs ... one was working with a different revision. weird!! :D

@gierens gierens requested a review from PThorpe92 August 30, 2023 03:39
@gierens
Copy link
Member Author

gierens commented Aug 30, 2023

Alright, now it should be ready for review and merging. That was certainly a weird issue. The test output referenced code not actually on the branch. No idea what exactly went wrong there. Must have been something with the merge conflict I had to resolve I guess.

Copy link
Member

@PThorpe92 PThorpe92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PThorpe92
Copy link
Member

Ok I thought i was hallucinating.. cuz none of that code was local on my machine. I did have to update the branch with the syntax fixes that I updated the main branch with to get it to pass tho.

But either way, this doesn't break Eza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants