Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use array to create deployment command #240

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

smol-ninja
Copy link
Member

@smol-ninja smol-ninja commented Dec 18, 2023

Closes #239

This PR corrects the deployment command created by deploy-multi-chains script. Now it generates a command as the following:

~ forge script script/DeployDeterministicPeriphery.s.sol --rpc-url https://sepolia.infura.io/v3/68967a55fb91488684a9c1000f321d7f --sig 'run(string)' 'ChainID 11155111, Version 1.1.0' -vvv --with-gas-price 15000000000

@andreivladbrg
Copy link
Member

can you make the change from this commit sablier-labs/v2-core@d5a14f4 here as well and then merge it directly?

@smol-ninja smol-ninja force-pushed the fix/CREATE2-salt-interpolation branch from b2d3941 to a5bb250 Compare December 22, 2023 16:25
@smol-ninja
Copy link
Member Author

@smol-ninja smol-ninja merged commit 07dc805 into build/multi-chain-script Dec 24, 2023
5 of 6 checks passed
@smol-ninja smol-ninja deleted the fix/CREATE2-salt-interpolation branch December 24, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants