Proposing packages upgrade #441
Conversation
🦋 Changeset detectedLatest commit: 0a4bdaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
I have read the CLA Document and I hereby sign the CLA |
This reverts commit 2d0da11.
| }, | ||
| "peerDependencies": { | ||
| "@wagmi/core": ">= 0.3.8 < 0.8.0" | ||
| "wagmi": "^0.10.10" |
There was a problem hiding this comment.
why does it change from @wagmi/core to wagmi? iirc wagmi is a react specific package but the connector doesn't care if it will be used in react or other framework, that's why it used @wagmi/core
There was a problem hiding this comment.
Understood, reverting to wagmi/core but bumping the version
There was a problem hiding this comment.
@mikhailxyz I did push the change let me know if somethig else is required
There was a problem hiding this comment.
I've just added a minor comment about version range for wagmi dep. Going to test the PR now
There was a problem hiding this comment.
I cannot get it working in the wagmi example app, I'm getting an error:
Type 'SafeConnector' is not assignable to type 'Connector<any, any, any>'.
Property 'onAccountsChanged' is protected but type 'SafeConnector' is not a class derived from 'Connector<Provider, Options, Signer>'.
I also had to remove the defaultChains import:
https://wagmi.sh/react/migration-guide#chain-exports
| }, | ||
| "peerDependencies": { | ||
| "@wagmi/core": ">= 0.3.8 < 0.8.0" | ||
| "@wagmi/core": "^0.8.18" |
There was a problem hiding this comment.
does it really require ^0.8.18 or it can work with any 0.8.x version? If it can it's better to make the version requirement less restrictive
There was a problem hiding this comment.
Could you please also update the example wagmi app to use 0.8.x?
|
Hey sir, I've iterated on your PR here: #445. I'm sorry but I have to close this because we need to get the fix released |
From [CHANGELOG.md]:
Unreleased - 1.3.0
Minor Changes
Patch Changes
This PR will allow the latest WAGMI and Web3modal apps to utilize SafeApps. Those changes were tested locally and in production on: https://defioracles.org/