Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposing packages upgrade #441

Closed
wants to merge 5 commits into from
Closed

Proposing packages upgrade #441

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0ce46d
updating versions of wagmi to be compatible with latest wagmi and web…
bannik Jan 24, 2023
2d0da11
adding changelog and bumping version
bannik Jan 24, 2023
4c12ae7
Revert "adding changelog and bumping version"
bannik Jan 24, 2023
38b746a
adding a changeset
bannik Jan 24, 2023
0a4bdaf
switching wagmi to wagmi/core
bannik Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/safe-apps-wagmi/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# @gnosis.pm/safe-apps-wagmi

## Unreleased - 1.3.0

### Minor Changes

- b0ce46d: Add support for wagmi 0.10.x

### Patch Changes

- Updated dependencies [b0ce46d]
- @gnosis.pm/[email protected]
- @gnosis.pm/[email protected]
- [email protected]

## 1.2.0

### Minor Changes
Expand Down
12 changes: 6 additions & 6 deletions packages/safe-apps-wagmi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@gnosis.pm/safe-apps-wagmi",
"version": "1.2.0",
"version": "1.3.0",
"description": "WAGMI connector for Safe Apps",
"main": "dist/index.js",
"typings": "dist/index.d.ts",
Expand All @@ -22,15 +22,15 @@
"author": "Safe (https://gnosis-safe.io)",
"license": "MIT",
"dependencies": {
"@gnosis.pm/safe-apps-provider": "^0.15.0",
"@gnosis.pm/safe-apps-sdk": "^7.7.0"
"@gnosis.pm/safe-apps-provider": "^0.15.1",
"@gnosis.pm/safe-apps-sdk": "^7.8.0"
},
"peerDependencies": {
"@wagmi/core": ">= 0.3.8 < 0.8.0"
"wagmi": "^0.10.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does it change from @wagmi/core to wagmi? iirc wagmi is a react specific package but the connector doesn't care if it will be used in react or other framework, that's why it used @wagmi/core

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, reverting to wagmi/core but bumping the version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikhailxyz I did push the change let me know if somethig else is required

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just added a minor comment about version range for wagmi dep. Going to test the PR now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot get it working in the wagmi example app, I'm getting an error:

Type 'SafeConnector' is not assignable to type 'Connector<any, any, any>'.
  Property 'onAccountsChanged' is protected but type 'SafeConnector' is not a class derived from 'Connector<Provider, Options, Signer>'.

I also had to remove the defaultChains import:
https://wagmi.sh/react/migration-guide#chain-exports

},
"devDependencies": {
"@wagmi/core": "^0.7.6",
"ethers": "^5.7.1"
"wagmi": "^0.10.10",
"ethers": "^5.7.2"
},
"repository": {
"type": "git",
Expand Down
Loading