Quick deployments from bundling stage #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EstebanRomero84
requested review from
npiccolo,
franciscoperezsammartino and
andresrivas-sf
EstebanRomero84
commented
Nov 28, 2023
| @@ -149,7 +149,6 @@ export default abstract class QuickPromotionCommand<T extends typeof SfCommand> | |||
| */ | |||
| private buildPromoteOptions(deployId: string): void { | |||
| this.deployOptions = { | |||
| testLevel: 'Default', | |||
There was a problem hiding this comment.
This is the main change: we don't need to send testLevel on a quick promotion request.
There was a problem hiding this comment.
The testLevel is optional right ?
There was a problem hiding this comment.
Nice find
There was a problem hiding this comment.
We don't need to specify a test level on a quick deploy since it only deploy metadata, it does't run the tests. They were run in the previous validate-only deployment.
EstebanRomero84
commented
Nov 28, 2023
| @@ -5,7 +5,7 @@ | |||
| * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause | |||
| */ | |||
|
|
|||
| import { spawnSync } from 'child_process'; | |||
| import { spawnSync } from 'node:child_process'; | |||
There was a problem hiding this comment.
Needed to solve eslint error after dev dependencies update.
molson-sfdc
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update quickPromotion to not send testLevel. This will allow to perform quick promotions from the bundling stage.
What issues does this PR fix or reference?
@W-14338568@
Functionality Before
We send testLevel on quick promotion requests. This makes the transaction to fail due to new validation.
Functionality After
We don't send testLevel on quick promotion requests.