Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-16197665 Add specifier for message #801

Merged
merged 6 commits into from
Sep 26, 2024
Merged

W-16197665 Add specifier for message #801

merged 6 commits into from
Sep 26, 2024

Conversation

iowillhoit
Copy link
Contributor

What does this PR do?

We will be changing how util.format works when formatting messages.
Specifiers (eg %s) will be required for the data to be rendered. As is, it appends data if no matching specifier is found.

What issues does this PR fix or reference?

More info here: forcedotcom/sfdx-core#1099
@W-16197665@

@iowillhoit iowillhoit requested a review from a team as a code owner September 24, 2024 16:01
Copy link
Contributor

@jshackell-sfdc jshackell-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my edits

messages/package_delete.md Outdated Show resolved Hide resolved
messages/package_version_delete.md Outdated Show resolved Hide resolved
test/commands/package/packageCreateAndDelete.nut.ts Outdated Show resolved Hide resolved
test/commands/package/packageVersion.nut.ts Outdated Show resolved Hide resolved
test/commands/package/version.delete.test.ts Outdated Show resolved Hide resolved
iowillhoit and others added 3 commits September 26, 2024 15:37
Co-authored-by: Juliet Shackell <[email protected]>
Co-authored-by: Juliet Shackell <[email protected]>
Co-authored-by: Juliet Shackell <[email protected]>
@iowillhoit iowillhoit merged commit 0061a67 into main Sep 26, 2024
13 checks passed
@iowillhoit iowillhoit deleted the ew/specifier branch September 26, 2024 22:00
@iowillhoit iowillhoit changed the title Add specifier for message W-16197665 Add specifier for message Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants