Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-16197665 Add specifier for message #801

Merged
merged 6 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion messages/package_delete.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ The request to delete this package was canceled

# humanSuccess

Successfully deleted the package.
Successfully deleted the package with ID: %s

# humanSuccessUndelete

Expand Down
2 changes: 1 addition & 1 deletion messages/package_version_delete.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ The request to delete this package version has been canceled.

# humanSuccess

Successfully deleted the package version.
Successfully deleted the package version with ID: %s

# humanSuccessUndelete

Expand Down
2 changes: 1 addition & 1 deletion test/commands/package/packageCreateAndDelete.nut.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ describe('package create/update/delete', () => {
it('should delete a package - human readable results', () => {
const command = `package:delete -p ${pkgName} -v ${session.hubOrg.username} --no-prompt`;
const output = execCmd(command, { ensureExitCode: 0 }).shellOutput.stdout;
expect(output).to.contain('Successfully deleted the package. 0Ho');
expect(output).to.contain('Successfully deleted the package with ID: 0Ho');
});
});
describe('create/update/delete - json results', () => {
Expand Down
2 changes: 1 addition & 1 deletion test/commands/package/packageVersion.nut.ts
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ describe('package:version:*', () => {
const id = deletableVersionIds.pop();
const command = `package:version:delete -p ${id} --noprompt`;
const result = execCmd<[PackageSaveResult]>(command, { ensureExitCode: 0 }).shellOutput.stdout;
expect(result).to.contain(`Successfully deleted the package version. ${id}`);
expect(result).to.contain(`Successfully deleted the package version with ID: ${id}`);
});
});

Expand Down
2 changes: 1 addition & 1 deletion test/commands/package/version.delete.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ describe('package:version:delete', () => {
const results: PackageSaveResult = await command.run();
expect(results.id).to.equal('testId');
expect(uxSuccessStub.calledOnce).to.be.true;
expect(uxSuccessStub.args[0][0]).to.equal('Successfully deleted the package version. testId');
expect(uxSuccessStub.args[0][0]).to.equal('Successfully deleted the package version with ID: testId');
expect(results.id).to.equal('testId');
});
it('should undelete a package version', async () => {
Expand Down
Loading