Wr/esm #439
Merged
Wr/esm #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been linked to a new work item: W-14398571 |
mshanemc
approved these changes
Nov 2, 2023
mshanemc
requested changes
Nov 2, 2023
There was a problem hiding this comment.
while QA-ing, I found some issues.
in DevDeps, the types for inquirer were still the v8 types. We reference a lot of those in the code, but they're not in v9.
I updated the types to v9 to match the inquirer import, but it causes failures.
I pushed a commit that makes these changes so you'll be able to see the errors.
WillieRuemmele
force-pushed
the
wr/esm
branch
from
bdc0414 to
814ff1d
Compare
mshanemc
approved these changes
Nov 6, 2023
|
previous QA (linked into sf) ✅ create a objects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
converts to ESM
What issues does this PR fix or reference?
@W-14398571@