Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Amazon 2023, Debian 12, Ubuntu 24.04, removed EOL and BSD OSs and Python 2.7 support #1987

Merged
merged 76 commits into from
Jul 11, 2024

Conversation

dmurphy18
Copy link
Contributor

What does this PR do?

Adds support for Amazon 2023, Debian 11 and 12.
Removes support for Debian 7, 8 & 9, RHEL 6, Amazon Linux (RHEL 6 clone) and Python 2.7

What issues does this PR fix or reference?

Fixes: #1940, #1986

Previous Behavior

Amazon 2023, Debian 11 and 12 failed to install with bootstrap script

New Behavior

Amazon 2023, Debian 11 and 12 now install with bootstrap script.
Debian 7, 8 and 9, RHEL 6, Amazon Linux (RHEL 6 clone) and Python 2.7 are no longer supported

@dmurphy18 dmurphy18 self-assigned this Feb 2, 2024
@dmurphy18
Copy link
Contributor Author

Cleaned up script with shellcheck before removing the EOL OS and Python 2.7 support.

Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to leave all the ## DGM comments?

bootstrap-salt.sh Outdated Show resolved Hide resolved
bootstrap-salt.sh Show resolved Hide resolved
bootstrap-salt.sh Outdated Show resolved Hide resolved
@dmurphy18 dmurphy18 changed the title Added support for Amazon 2023, Debian 11 & 12, removed EOL OSs and Python 2.7 support [WIP] Added support for Amazon 2023, Debian 11 & 12, removed EOL OSs and Python 2.7 support Feb 5, 2024
@dmurphy18
Copy link
Contributor Author

Ensure the bootstrap script works on Centosstream 8 with redhat-lsb-core installed, it might be affecting distro

@Foorack
Copy link

Foorack commented Jun 20, 2024

CI indicates this is failing with Failed to run install_debian_onedir_deps()!!!, without any visible Error message.
Do we know why this is failing?

@dmurphy18
Copy link
Contributor Author

@Foorack WIP - Work In Progress, read the title. Still have to implement GitHub Actions runners

@dmurphy18
Copy link
Contributor Author

Running into issue with Amazon 2023 with current stable version Ruby 3.3.4 for Create Test Instance, reverting to original 2.6.10

11s
Run ## DGM Need to replace this
-----> Starting Test Kitchen (v3.6.0)
-----> Creating <stable-3006-amazon-2023>...
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: [1](https://github.com/saltstack/salt-bootstrap/actions/runs/9882490882/job/27295489413?pr=1987#step:6:1) actions failed.
>>>>>>     Create failed on instance <stable-3006-amazon-2023>.  Please see .kitchen/logs/stable-3006-amazon-2023.log for more details
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration
Error: Process completed with exit code 20.

@dmurphy18 dmurphy18 changed the title [WIP] Added support for Amazon 2023, Debian 11 & 12, removed EOL OSs and Python 2.7 support Added support for Debian 12, Ubuntu 24.,04, removed EOL OSs and Python 2.7 support Jul 11, 2024
@dmurphy18 dmurphy18 changed the title Added support for Debian 12, Ubuntu 24.,04, removed EOL OSs and Python 2.7 support Added support for Debian 12, Ubuntu 24.04, removed EOL OSs and Python 2.7 support Jul 11, 2024
@dmurphy18 dmurphy18 changed the title Added support for Debian 12, Ubuntu 24.04, removed EOL OSs and Python 2.7 support Added support for Debian 12, Ubuntu 24.04, removed EOL and BSD OSs and Python 2.7 support Jul 11, 2024
@dmurphy18 dmurphy18 changed the title Added support for Debian 12, Ubuntu 24.04, removed EOL and BSD OSs and Python 2.7 support Added support for Amazon 2023, Debian 12, Ubuntu 24.04, removed EOL and BSD OSs and Python 2.7 support Jul 11, 2024
bootstrap-salt.sh Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Minion bootstrap installation fails on Amazon Linux 2023
4 participants