Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debris-bed friction slip law #1101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeremy-brooks-1
Copy link

Add debris-bed friction slip relation.
Adding two new friction parameters, could set as constants in albany_input.yaml or read fields from MPAS mesh:
*bulkFrictionCoefficient
*basalDebrisFactor
There are corresponding changes in MPAS interface in MALI-Dev/ES3M repository.

Add debris-bed friction slip relation.
Adding two new friction parameters, could set as constants in
albany_input.yaml or read fields from MPAS mesh:
*bulkFrictionCoefficient
*basalDebrisFactor
There are corresponding changes in MPAS interface in MALI-Dev/ES3M
repository.
@jeremy-brooks-1
Copy link
Author

@mperego Here is the branch we mentioned on slack attempting to add debris-bed friction. Let me know if you need additional info, thanks!

@jeremy-brooks-1
Copy link
Author

Corresponding MPAS PR is: MALI-Dev/E3SM#135

@@ -714,7 +699,7 @@ void velocity_solver_extrude_3d_grid(int nLayers, int globalTrianglesStride,

discretizationList->set("Workset Size", discretizationList->get("Workset Size", -1));

discretizationList->set("Method", discretizationList->get("Method", "STKExtruded")); //set to STKExtruded is not defined
discretizationList->set("Method", discretizationList->get("Method", "Extruded")); //set to Extruded is not defined
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you based this PR off of a odler version of Albany, can you please rebase to this branch to Albany master? (or merge master into this branch?)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, can do

switch (flowRate_type) {
case FLOW_RATE_TYPE::CONSTANT: {
beta(cell,ipt) /= std::pow ( u_norm(cell,ipt) + bedRoughnessValue*scaling*flowRate_val*std::pow(NVal,n), power); //bedRoughness in km
// beta(cell,ipt) = ((muValue * NVal * std::pow (u_norm(cell,ipt), power-1.0)) / std::pow ( u_norm(cell,ipt) + bedRoughnessValue*scaling*flowRate_val*std::pow(NVal,n), power)) + (bulkFrictionValue * NVal / u_norm(cell,ipt)) + (basalDebrisValue * u_norm(cell,ipt));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you thinking to uncomment this? As it is, the basal debris field and the bulk friction field are unused...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this should be uncommented thanks for catching that!

@mperego
Copy link
Collaborator

mperego commented Dec 20, 2024

@jeremy-brooks-1 thanks for working on this. Before this can be merged we should add a test that exercise this capability. I can help you with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants