Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sanity): update the title to be ellipsed when the text is too long #7380

Merged
merged 3 commits into from
Aug 20, 2024
Merged

fix(sanity): update the title to be ellipsed when the text is too long #7380

merged 3 commits into from
Aug 20, 2024

Conversation

RitaDias
Copy link
Contributor

Description

Before
image

After (hovering over the title text)
image

What to review

  • Double check the css makes sense

Testing

Manual testing

  • When no global bundle: the drop arrow should be next to the title, the title should behave as normal (if it's short or long)
  • With a global bundle but no version document: the drop down arrow should be next to the title
  • With a global bundle and document version selected: the drop down arrow and badge next to it, the title should behave as normal (ellipsing if it's too long). The whole content should be in the title

@RitaDias RitaDias requested a review from a team as a code owner August 19, 2024 09:09
@RitaDias RitaDias requested review from juice49 and removed request for a team August 19, 2024 09:09
@vercel Vercel
Copy link

vercel bot commented Aug 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 8:02am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 8:02am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 8:02am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 8:02am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 8:02am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 8:02am

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024 •
edited
Loading

Component Testing Report Updated Aug 20, 2024 8:18 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 49s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 36s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 48s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 17s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 19s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 26s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 1m 53s 30 0 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 20s 3 0 0

jordanl17
jordanl17 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@jordanl17 jordanl17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@RitaDias RitaDias requested a review from bjoerge August 20, 2024 08:01
@RitaDias RitaDias merged commit 32fde72 into corel Aug 20, 2024
42 checks passed
@RitaDias RitaDias deleted the corel-105-2 branch August 20, 2024 08:59
bjoerge pushed a commit that referenced this pull request Aug 20, 2024
@RitaDias @bjoerge
fix(sanity): update the title to be ellipsed when the text is too long (
32c7193 
#7380)

* fix(sanity): update the title to remain ellipsed when it's too long

* refactor(sanity): add title to the title (hovering)

* refactor(sanity): remove inline style for flex + hoist inline style
bjoerge pushed a commit that referenced this pull request Aug 20, 2024
@RitaDias @bjoerge
fix(sanity): update the title to be ellipsed when the text is too long (
7a18408 
#7380)

* fix(sanity): update the title to remain ellipsed when it's too long

* refactor(sanity): add title to the title (hovering)

* refactor(sanity): remove inline style for flex + hoist inline style
bjoerge pushed a commit that referenced this pull request Aug 20, 2024
@RitaDias @bjoerge
fix(sanity): update the title to be ellipsed when the text is too long (
dd088a5 
#7380)

* fix(sanity): update the title to remain ellipsed when it's too long

* refactor(sanity): add title to the title (hovering)

* refactor(sanity): remove inline style for flex + hoist inline style
RitaDias added a commit that referenced this pull request Aug 23, 2024
@RitaDias
fix(sanity): update the title to be ellipsed when the text is too long (
2de687f 
#7380)

* fix(sanity): update the title to remain ellipsed when it's too long

* refactor(sanity): add title to the title (hovering)

* refactor(sanity): remove inline style for flex + hoist inline style
RitaDias added a commit that referenced this pull request Aug 26, 2024
@RitaDias
fix(sanity): update the title to be ellipsed when the text is too long (
b63f9d2 
#7380)

* fix(sanity): update the title to remain ellipsed when it's too long

* refactor(sanity): add title to the title (hovering)

* refactor(sanity): remove inline style for flex + hoist inline style
juice49 pushed a commit that referenced this pull request Sep 3, 2024
@RitaDias @juice49
fix(sanity): update the title to be ellipsed when the text is too long (
3072699 
#7380)

* fix(sanity): update the title to remain ellipsed when it's too long

* refactor(sanity): add title to the title (hovering)

* refactor(sanity): remove inline style for flex + hoist inline style
RitaDias added a commit that referenced this pull request Oct 3, 2024
@RitaDias
fix(sanity): update the title to be ellipsed when the text is too long (
8fb457c 
#7380)

* fix(sanity): update the title to remain ellipsed when it's too long

* refactor(sanity): add title to the title (hovering)

* refactor(sanity): remove inline style for flex + hoist inline style
juice49 pushed a commit that referenced this pull request Oct 4, 2024
@RitaDias @juice49
fix(sanity): update the title to be ellipsed when the text is too long (
65de1b6 
#7380)

* fix(sanity): update the title to remain ellipsed when it's too long

* refactor(sanity): add title to the title (hovering)

* refactor(sanity): remove inline style for flex + hoist inline style
juice49 pushed a commit that referenced this pull request Oct 7, 2024
@RitaDias @juice49
fix(sanity): update the title to be ellipsed when the text is too long (
762f6ab 
#7380)

* fix(sanity): update the title to remain ellipsed when it's too long

* refactor(sanity): add title to the title (hovering)

* refactor(sanity): remove inline style for flex + hoist inline style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanl17 jordanl17 jordanl17 approved these changes

@bjoerge bjoerge bjoerge approved these changes

@juice49 juice49 Awaiting requested review from juice49 juice49 was automatically assigned from sanity-io/sdk

@pedrobonamin pedrobonamin Awaiting requested review from pedrobonamin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RitaDias @bjoerge @jordanl17