Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sanity): update the title to be ellipsed when the text is too long #7380

Merged
merged 3 commits into from
Aug 20, 2024
Merged

fix(sanity): update the title to be ellipsed when the text is too long #7380

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4bbb56
fix(sanity): update the title to remain ellipsed when it's too long
RitaDias Aug 19, 2024
e57ff42
refactor(sanity): add title to the title (hovering)
RitaDias Aug 19, 2024
e20aaa5
refactor(sanity): remove inline style for flex + hoist inline style
RitaDias Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions packages/sanity/src/structure/panes/document/documentPanel/header/DocumentHeaderTitle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,17 @@ import {DocumentIcon} from '@sanity/icons'
import {Flex, Text} from '@sanity/ui'
import {createElement, memo, type ReactElement} from 'react'
import {unstable_useValuePreview as useValuePreview, useTranslation} from 'sanity'
import {styled} from 'styled-components'

import {structureLocaleNamespace} from '../../../../i18n'
import {useDocumentPane} from '../../useDocumentPane'
import {DocumentPerspectiveMenu} from './perspective/DocumentPerspectiveMenu'

const TitleContainer = styled(Text)`
max-width: 100%;
min-width: 0;
`

export const DocumentHeaderTitle = memo(function DocumentHeaderTitle(): ReactElement {
const {connectionState, schemaType, title, value: documentValue} = useDocumentPane()
const subscribed = Boolean(documentValue) && connectionState !== 'connecting'
Expand Down Expand Up @@ -41,23 +47,21 @@ export const DocumentHeaderTitle = memo(function DocumentHeaderTitle(): ReactEle
}

return (
<Flex flex={1} gap={0}>
<Flex flex="none" gap={3} padding={2}>
<Text size={1}>{createElement(schemaType?.options?.icon || DocumentIcon)}</Text>
<Text
muted={!value?.title}
size={1}
textOverflow="ellipsis"
weight={value?.title ? 'semibold' : undefined}
>
{value?.title || (
<span style={{color: 'var(--card-muted-fg-color)'}}>
{t('panes.document-header-title.untitled.text')}
</span>
)}
</Text>
</Flex>

<Flex flex={1} align="center" gap={3} paddingX={2}>
<Text size={1}>{createElement(schemaType?.options?.icon || DocumentIcon)}</Text>
<TitleContainer
muted={!value?.title}
size={1}
textOverflow="ellipsis"
weight={value?.title ? 'semibold' : undefined}
title={value?.title}
>
{value?.title || (
<span style={{color: 'var(--card-muted-fg-color)'}}>
{t('panes.document-header-title.untitled.text')}
</span>
)}
</TitleContainer>
<Flex flex="none" gap={1}>
<DocumentPerspectiveMenu />
</Flex>
Expand Down
Loading