Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add markdown plugin back #7475

Merged
merged 1 commit into from
Dec 9, 2024
Merged

chore: add markdown plugin back #7475

merged 1 commit into from
Dec 9, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Sep 9, 2024

Now that sanity-plugin-markdown has v3 support it makes sense to add it back to the test studio

@stipsan stipsan requested a review from a team as a code owner September 9, 2024 10:21
@stipsan stipsan requested review from ricokahler and removed request for a team September 9, 2024 10:21
Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:47am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:47am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:47am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:47am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:47am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 9:47am

Copy link
Contributor

github-actions bot commented Sep 9, 2024

No changes to documentation

@stipsan stipsan enabled auto-merge September 9, 2024 10:24
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Component Testing Report Updated Dec 9, 2024 9:47 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 39s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 54s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 7s 2 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 9s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 42s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 45s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 41s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 55s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link

socket-security bot commented Sep 9, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: filesystem +12 9.84 MB

View full report↗︎

@bjoerge bjoerge force-pushed the add-markdown-plugin branch from c619006 to 831fff1 Compare December 9, 2024 09:25
@bjoerge bjoerge removed the request for review from a team December 9, 2024 09:25
Copy link
Contributor

github-actions bot commented Dec 9, 2024

⚡️ Editor Performance Report

Updated Mon, 09 Dec 2024 09:47:08 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 22.2 efps (45ms) 22.7 efps (44ms) -1ms (-2.2%)
article (body) 56.3 efps (18ms) 59.9 efps (17ms) -1ms (-5.9%)
article (string inside object) 23.8 efps (42ms) 25.0 efps (40ms) -2ms (-4.8%)
article (string inside array) 21.3 efps (47ms) 22.0 efps (46ms) -2ms (-3.2%)
recipe (name) 45.5 efps (22ms) 47.6 efps (21ms) -1ms (-4.5%)
recipe (description) 52.6 efps (19ms) 52.6 efps (19ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (7ms) +0ms (-/-%)
synthetic (title) 18.2 efps (55ms) 18.5 efps (54ms) -1ms (-1.8%)
synthetic (string inside object) 18.2 efps (55ms) 18.7 efps (54ms) -2ms (-2.7%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 45ms 49ms 61ms 336ms 487ms 12.5s
article (body) 18ms 20ms 36ms 98ms 331ms 5.9s
article (string inside object) 42ms 44ms 51ms 256ms 252ms 7.1s
article (string inside array) 47ms 51ms 60ms 105ms 292ms 7.7s
recipe (name) 22ms 24ms 28ms 42ms 0ms 7.6s
recipe (description) 19ms 20ms 22ms 40ms 0ms 4.7s
recipe (instructions) 7ms 9ms 11ms 33ms 0ms 3.5s
synthetic (title) 55ms 61ms 107ms 353ms 822ms 13.8s
synthetic (string inside object) 55ms 58ms 69ms 446ms 1002ms 9.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 44ms 48ms 58ms 202ms 218ms 12.2s
article (body) 17ms 20ms 22ms 83ms 56ms 5.2s
article (string inside object) 40ms 44ms 51ms 245ms 255ms 7.2s
article (string inside array) 46ms 48ms 52ms 71ms 164ms 7.2s
recipe (name) 21ms 24ms 26ms 63ms 0ms 7.6s
recipe (description) 19ms 22ms 24ms 66ms 0ms 5.0s
recipe (instructions) 7ms 9ms 10ms 18ms 3ms 3.4s
synthetic (title) 54ms 56ms 63ms 249ms 439ms 16.1s
synthetic (string inside object) 54ms 57ms 67ms 666ms 805ms 9.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants