Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add back the @sanity/color-input plugin to test studio #7502

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Sep 13, 2024

Description

It was removed some time back, it's useful to have it for perf testing reasons, and to make easier detect if changes in the studio breaks the plugin

Testing

Try it here https://test-studio-git-ad-back-color-input-plugin.sanity.dev/test/structure/input-plugin;colorTest;0575367a-08b6-4b88-b953-2cbf5e63fc55 it works 🥳

Notes for release

N/A

@stipsan stipsan requested a review from a team as a code owner September 13, 2024 09:40
@stipsan stipsan requested review from ricokahler and removed request for a team September 13, 2024 09:40
Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 10:41am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 10:41am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 10:41am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 10:41am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 10:41am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 10:41am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Sep 13, 2024

Component Testing Report Updated Dec 9, 2024 10:37 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 10s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 7s 2 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 10s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 42s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 43s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 39s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 54s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link

socket-security bot commented Sep 13, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sanity/[email protected] Transitive: environment, eval +14 11.1 MB sanity-io

View full report↗︎

bjoerge
bjoerge previously approved these changes Dec 9, 2024
@bjoerge bjoerge force-pushed the ad-back-color-input-plugin branch from 56fb483 to a7ce001 Compare December 9, 2024 09:38
@bjoerge bjoerge enabled auto-merge December 9, 2024 09:39
Copy link
Contributor

github-actions bot commented Dec 9, 2024

⚡️ Editor Performance Report

Updated Mon, 09 Dec 2024 10:38:56 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 26.3 efps (38ms) 23.3 efps (43ms) +5ms (+13.2%)
article (body) 59.5 efps (17ms) 59.5 efps (17ms) +0ms (-/-%)
article (string inside object) 25.6 efps (39ms) 25.0 efps (40ms) +1ms (+2.6%)
article (string inside array) 24.4 efps (41ms) 20.8 efps (48ms) +7ms (+17.1%)
recipe (name) 47.6 efps (21ms) 45.5 efps (22ms) +1ms (+4.8%)
recipe (description) 52.6 efps (19ms) 54.1 efps (19ms) -1ms (-2.6%)
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (7ms) -1ms (-/-%)
synthetic (title) 17.2 efps (58ms) 17.5 efps (57ms) -1ms (-1.7%)
synthetic (string inside object) 17.7 efps (57ms) 19.0 efps (53ms) -4ms (-7.1%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 41ms 44ms 166ms 198ms 10.6s
article (body) 17ms 19ms 23ms 91ms 217ms 5.6s
article (string inside object) 39ms 46ms 54ms 269ms 308ms 7.3s
article (string inside array) 41ms 44ms 48ms 194ms 151ms 7.3s
recipe (name) 21ms 23ms 27ms 55ms 0ms 8.3s
recipe (description) 19ms 21ms 25ms 96ms 0ms 4.8s
recipe (instructions) 7ms 10ms 11ms 15ms 0ms 3.5s
synthetic (title) 58ms 61ms 97ms 540ms 1185ms 19.1s
synthetic (string inside object) 57ms 62ms 71ms 130ms 930ms 8.7s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 47ms 56ms 180ms 214ms 10.9s
article (body) 17ms 18ms 23ms 183ms 209ms 5.4s
article (string inside object) 40ms 43ms 44ms 107ms 170ms 7.0s
article (string inside array) 48ms 53ms 67ms 185ms 401ms 7.8s
recipe (name) 22ms 23ms 29ms 59ms 0ms 8.4s
recipe (description) 19ms 20ms 24ms 40ms 0ms 4.9s
recipe (instructions) 7ms 8ms 10ms 19ms 0ms 3.2s
synthetic (title) 57ms 60ms 64ms 121ms 442ms 14.0s
synthetic (string inside object) 53ms 56ms 63ms 311ms 505ms 8.9s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@bjoerge bjoerge added this pull request to the merge queue Dec 9, 2024
Merged via the queue into next with commit 960186d Dec 9, 2024
35 of 37 checks passed
@bjoerge bjoerge deleted the ad-back-color-input-plugin branch December 9, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants