Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removeAt instead of removeLast for SDK <35 compatibility #226

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

sargunv
Copy link
Owner

@sargunv sargunv commented Jan 3, 2025

Run Android instrumentation tests against API levels 24 and 35, and fix a compatibility issue by using removeAt instead of removeLast.

fixes #224

@sargunv sargunv changed the title feat: test Android API levels 24 and 35 fix: removeAt instead of removeLast for SDK <35 compatibility Jan 3, 2025
@sargunv sargunv marked this pull request as ready for review January 3, 2025 01:05
@sargunv sargunv changed the base branch from android_disable_texture_mode to graphite-base/226 January 3, 2025 01:11
@sargunv sargunv force-pushed the fix_android_removeat_instead_of_removelast branch from d1f848d to b55d2e8 Compare January 3, 2025 01:11
@sargunv sargunv force-pushed the graphite-base/226 branch from 29f827a to 8e7c97e Compare January 3, 2025 01:11
@sargunv sargunv changed the base branch from graphite-base/226 to main January 3, 2025 01:12
@sargunv sargunv force-pushed the fix_android_removeat_instead_of_removelast branch from b55d2e8 to b9ec32c Compare January 3, 2025 01:12
@sargunv sargunv merged commit abf9996 into main Jan 3, 2025
9 checks passed
Copy link
Owner Author

sargunv commented Jan 3, 2025

Merge activity

  • Jan 2, 5:30 PM PST: A user merged this pull request with Graphite.

@sargunv sargunv deleted the fix_android_removeat_instead_of_removelast branch January 3, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on some samples on Android
1 participant