Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configure JVM target to a reasonable LTS (11) #227

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

sargunv
Copy link
Owner

@sargunv sargunv commented Jan 3, 2025

Previously we used whatever target we built with (23). But this is a library, so we should be compatible with currently supported LTS versions.

fixes #223

@sargunv sargunv changed the title feat: configure JVM target from gradle.properties feat: configure JVM target to a reasonably old currently supported LTS (11) Jan 3, 2025
@sargunv sargunv changed the title feat: configure JVM target to a reasonably old currently supported LTS (11) feat: configure JVM target to a reasonable LTS (11) Jan 3, 2025
@sargunv sargunv marked this pull request as ready for review January 3, 2025 01:06
@sargunv sargunv changed the title feat: configure JVM target to a reasonable LTS (11) fix: configure JVM target to a reasonable LTS (11) Jan 3, 2025
@sargunv sargunv force-pushed the fix_android_removeat_instead_of_removelast branch 2 times, most recently from b55d2e8 to b9ec32c Compare January 3, 2025 01:12
@sargunv sargunv force-pushed the fix_desktop_set_jvm_target_to_11 branch from 39fe957 to 8e271d4 Compare January 3, 2025 01:12
@sargunv sargunv changed the base branch from fix_android_removeat_instead_of_removelast to graphite-base/227 January 3, 2025 01:30
@sargunv sargunv force-pushed the fix_desktop_set_jvm_target_to_11 branch from 8e271d4 to 04b0ba9 Compare January 3, 2025 01:30
@sargunv sargunv force-pushed the graphite-base/227 branch from b9ec32c to abf9996 Compare January 3, 2025 01:30
@sargunv sargunv changed the base branch from graphite-base/227 to main January 3, 2025 01:31
@sargunv sargunv force-pushed the fix_desktop_set_jvm_target_to_11 branch from 04b0ba9 to a715ae4 Compare January 3, 2025 01:31
@sargunv sargunv merged commit 5b55034 into main Jan 3, 2025
9 checks passed
Copy link
Owner Author

sargunv commented Jan 3, 2025

Merge activity

  • Jan 2, 5:49 PM PST: A user merged this pull request with Graphite.

@sargunv sargunv deleted the fix_desktop_set_jvm_target_to_11 branch January 3, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set proper LTS JDK target for desktop instead of JDK 23
1 participant