Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not close client connection after returning HTTP status code 304 #963

Merged
merged 8 commits into from
Nov 21, 2024
Merged

Do not close client connection after returning HTTP status code 304 #963

merged 8 commits into from
Nov 21, 2024

Commits on Nov 21, 2024

  1. martian/log: add helper function to easily display logs in test

    @mmatczuk
    mmatczuk committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    6c2259e View commit details
    Browse the repository at this point in the history

  2. martian: extract isHeaderOnlySpec() from shouldChunk()

    @mmatczuk
    mmatczuk committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d68d047 View commit details
    Browse the repository at this point in the history

  3. martian: use writeHeadResponse() for all header-only response types 

    Note that res.Body == http.NoBody is not always the case ex. when it's wrapped, or comes from http/2.
    @mmatczuk
    mmatczuk committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    65f10c0 View commit details
    Browse the repository at this point in the history

  4. martian(proxy): harden roundTrip() on header-only responses

    @mmatczuk
    mmatczuk committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    0b984bd View commit details
    Browse the repository at this point in the history

  5. martian: add http 304 test 

    Test ensures that after responding with status code 304 the connection is left intact.
    @mmatczuk
    mmatczuk committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    8ff5807 View commit details
    Browse the repository at this point in the history

  6. chore(martian): rename writeHeadResponse() to writeHeaderOnlyResponse()

    @mmatczuk
    mmatczuk committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    9fa9113 View commit details
    Browse the repository at this point in the history

  7. chore(martian): move writeHeaderOnlyResponse() to proxy_conn.go

    @mmatczuk
    mmatczuk committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    67063b4 View commit details
    Browse the repository at this point in the history

  8. martian: when handling 101 response panic on response read after ucon… 

    …n extraction

The std http package returns the underlying connection in body of 101 response. The response body needs to be removed form the response.
Make reads from the replaced body panic to ensure that it's always handled correctly.
    @mmatczuk
    mmatczuk committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    e662d13 View commit details
    Browse the repository at this point in the history