Properly handle shoes styles and keyword args in Lacci initialize() methods #473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle positional arguments, not just styles, in Drawable#initialize. That makes it obvious how to combine positional with keyword args. Use Shoes default styles for default argument values instead of initialize default params. Add some tests for default argument values.
There are a few places we still don't do this, mostly flow and stack. We still need to rework a few places where we do weird nonstandard things -- e.g. margin should change to Drawable, not separately Flow/Stack/Para. Para needs to stop passing all "extra" args as HTML attributes, which doesn't even work for the styles (margin, align) it's using it for. But those can be a later PR.
Checklist