FIX: edit->Add compass #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xulman
commented
Sep 3, 2020
xulman
commented
- is not asking/complaining for Vector3f, and shows dialog instead...
- has nicer dialog
- optionally be in the TL corner as overlay
- optionally be as a part of the scene
- tiny bit of refactoring
|
I would not merge until issue #286 is resolved |
- is not asking/complaining for Vector3f, and shows dialog instead... - has nicer dialog - optionally be in the TL corner as overlay - optionally be as a part of the scene - tiny bit of refactoring
|
rebased against master I gave you all I had regarding the orientation compass (as three-axes in the centre, as a box in the corner, rotations fixed-syncing with camera) the stage is yours now |
|
@xulman we ended up with a few issues with the compass. I do think we need one. I'm not sure what your thoughts are currently about which implementation/approach we should continue. |
|
hi @kephale, @skalarproduktraum I'm okay with any compass in the end :-) (sorry for so very late reply) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.