TypedIOService interface #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frauzufall
force-pushed
the
typedioservice
branch
from
9b09f4c to
50c8806
Compare
This was referenced Aug 13, 2020
This is an interface which can be used to write IOServices opening and saving a specific type. The TypedIOServiceTest class demonstrates how to do that with an exemplary TextIOService. So far, IO services like DatasetIOService or TableIOServcie don't share a common IOService interface.
* .. which was originally implemented in the TypedIOServiceTest for testing the TypedIOService architecture
ctrueden
force-pushed
the
typedioservice
branch
from
50c8806 to
bba50af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the #395 branch.
When trying to make use of the
LocationAPI inscijava-tableI realized that there is no common IO service interface for typed IO services, so I wroteTypedIOService. I think it simplifies things a lot, have a look atTextIOServiceandDefaultTextIOService.