Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist/debian: add trailer line #66

Merged
merged 2 commits into from
Jan 2, 2024
Merged

dist/debian: add trailer line #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd8d16d
dist/debian: wrap long line
tchaikov Jan 2, 2024
aabb3b3
dist/debian: add trailer line
tchaikov Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dist/debian/changelog.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
%{product}-cqlsh (%{version}-%{release}-%{revision}) %{codename}; urgency=medium

* New release

-- Israel Fruchter <[email protected]> %{timestamp}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchaikov nice of you to sign in my name :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was you who created this changelog entry. ;-)

9 changes: 8 additions & 1 deletion dist/debian/debian_files_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import datetime
import string
import os
import shutil
Expand Down Expand Up @@ -47,7 +48,13 @@ class DebianFilesTemplate(string.Template):
shutil.copytree('dist/debian/debian', 'build/debian/debian')

s = DebianFilesTemplate(changelog_template)
changelog_applied = s.substitute(product=product, version=version, release=release, revision='1', codename='stable')
now = datetime.datetime.now(tz=datetime.timezone.utc)
changelog_applied = s.substitute(product=product,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was done on other packages ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. adding timestamp ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(we assumed for long time, that the change log is mostly not touched)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet. i created this change in hope to silence the warnings and to comply to the debian packaging policies. will take care of other packages when i have more free cycles.

version=version,
release=release,
revision='1',
codename='stable',
timestamp=now.strftime("%a, %d %b %Y %H:%M:%S %z"))

s = DebianFilesTemplate(control_template)
control_applied = s.substitute(product=product)
Expand Down