Add start time, end time, and date to each Place card #8
Conversation
infinite_scroll_list.js - Increased the default height of the place cards in getCardHeight() by 82px place_list_item.html - Added place start time tag - Added place display date to be centered above the place name - Added place end time tag
infinite_scroll_list.js - Added a check that if we are showing places and the last entry does not have a display_end_time, we create a display_end_time to be 1 hour later than the start time
|
Testing:
|
|
@JGreenlee @shankari could you take a quick look and make sure this seems correct with what UNSW asked for?
|
|
ToDo:
|
There was a problem hiding this comment.
Please read the actual request from e-mission/e-mission-docs#871 for context.
www/js/diary/infinite_scroll_list.js
Outdated
| if (!$scope.data.displayTimelineEntries[$scope.data.displayTimelineEntries.length-1].display_end_time && $scope.showPlaces) { | ||
| $scope.data.displayTimelineEntries[$scope.data.displayTimelineEntries.length-1].display_end_time = moment($scope.data.displayTimelineEntries[$scope.data.displayTimelineEntries.length-1].enter_fmt_time).parseZone().add(1, 'hour').format("h:mm A"); |
There was a problem hiding this comment.
If you see the discussion on e-mission/e-mission-docs#871, I think that they expect it to be the end of the day.
|
@sebastianbarry I would suggest that you hold off on the change below
pending the discussion in Please do fix my comment above and indicate when this is ready to merge. |
|
Addressed comment #8 (comment) in commit e521390 Testing: Holding off on the other change, as indicated in your message @shankari. This should be ready to merge then |
|
@sebastianbarry we are deploying code from https://github.com/e-mission/e-mission-phone/tree/survey_refactor_expansion In general, I review code and then merge it... |
infinite_scroll_list.js
place_list_item.html