Migrate to vite #145
Merged
Migrate to vite #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sats-connect ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aryzing
force-pushed
the
edu/migrate-to-vite
branch
2 times, most recently
from
59318a5 to
aa7ecf3
Compare
aryzing
force-pushed
the
edu/migrate-to-vite
branch
from
7bb5f9d to
e81d2e4
Compare
m-aboelenein
previously approved these changes
Jul 9, 2024
m-aboelenein
reviewed
Jul 9, 2024
m-aboelenein
reviewed
Jul 9, 2024
m-aboelenein
reviewed
Jul 9, 2024
m-aboelenein
reviewed
Jul 9, 2024
|
@aryzing PR looks good overall 👍, just left a few comments on things I noticed while testing |
|
m-aboelenein
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea was to only migrate to Vite in this PR, although apparently some of the other changes had not yet been merged? Not quite sure what happened, was under the impression they were already in dev