ENG-3296 sats-connect repeat-inscriptions #50

m-aboelenein · 2023-11-27T13:48:25Z

No description provided.

src/inscriptions/createRepeatInscriptions.ts

teebszet

lgtm. one open question, and let me add extension support before creating the new version here

src/provider/types.ts

github-actions · 2023-11-28T06:26:16Z

Test this PR with npm i --save-exact [email protected]

m-aboelenein · 2023-11-28T09:04:19Z

@teebszet Thanks for addressing these issues 🙌 all looks well regarding your updates

add createRepeatInscriptions method

b39e9aa

m-aboelenein requested review from victorkirov and teebszet November 27, 2023 13:48

m-aboelenein self-assigned this Nov 27, 2023

teebszet reviewed Nov 28, 2023

View reviewed changes

src/inscriptions/createRepeatInscriptions.ts Outdated Show resolved Hide resolved

teebszet reviewed Nov 28, 2023

View reviewed changes

src/provider/types.ts Outdated Show resolved Hide resolved

teebszet added 2 commits November 28, 2023 13:44

chore: export the new function

7004218

fix: bad import

546d3c4

teebszet added the Release 1.2.0 label Nov 28, 2023

teebszet added 3 commits November 28, 2023 14:00

chore: use --save-exact in pr comment

196686b

fix: should call provider create repeat inscriptions

9a409d5

fix: prefer duplicate type for consuming apps

2cfe80c

teebszet approved these changes Nov 28, 2023

View reviewed changes

teebszet mentioned this pull request Nov 28, 2023

feat: example for repeat inscriptions secretkeylabs/sats-connect-example#18

Merged

teebszet merged commit 5638dce into develop Nov 28, 2023
3 checks passed

teebszet deleted the mahmoud/eng-3296-sats-connect-repeat-inscriptions-createrepeatinscriptions branch November 28, 2023 13:59

teebszet mentioned this pull request Nov 30, 2023

[ENG-3314] feat: support repeat minter secretkeylabs/xverse-web-extension#687

Merged

8 tasks

Provide feedback