Deprecate Native API #1143
Closed
Deprecate Native API #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shah, Karan <[email protected]>
Signed-off-by: Shah, Karan <[email protected]>
Signed-off-by: Shah, Karan <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: Shah, Karan <[email protected]>
Signed-off-by: Shah, Karan <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: Shah, Karan <[email protected]>
Signed-off-by: Shah, Karan <[email protected]>
tanwarsh
requested review from
psfoley,
kta-intel,
theakshaypant,
teoparvanov,
MasterSkepticista,
rahulga1,
rajithkrishnegowda and
ishaileshpant
and removed request for
psfoley
teoparvanov
reviewed
Nov 13, 2024
docs/developer_guide/advanced_topics/overriding_plan_settings.rst
Outdated
Show resolved
Hide resolved
| @@ -4,7 +4,7 @@ | |||
| .. _running_notebook: | |||
|
|
|||
| ********************************** | |||
| Aggregator-Based Workflow Tutorial | |||
| Aggregator-Based Workflow Tutorial (Deprecated) | |||
There was a problem hiding this comment.
This isn't related to Python API, so please revert this change
There was a problem hiding this comment.
@teoparvanov, I think we should rewrite/delete this as the title is Aggregator based but the the tutorial is using python native API.
https://openfl.readthedocs.io/en/latest/developer_guide/running_the_federation.notebook.html
There was a problem hiding this comment.
Then my suggestion is to delete the entire page.
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
…2-Nov-24 Signed-off-by: yes <[email protected]>
This reverts commit b5e8bad.
|
@tanwarsh Because the tip has moved way ahead, a better option is to create patches of your changes, close this PR, and create a new branch from develop with your patches applied. |
|
Closing this PR due to rebase issues. Create new PR #1153 for the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate Python API:
This PR will be merged after Interactive API Deprecation #1125