Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the Python Native API #1153

Closed
wants to merge 8 commits into from

Conversation

tanwarsh
Copy link
Collaborator

Deprecate Python API:

  1. Mark Python native API as deprecated in the doc
  2. Remove Python native API code.
  3. Remove github workflow realted code.
  4. Remove test related to Python native API.
  5. Remove Tutorials related to Python native API.

This PR will be merged after discussion on FETS Chanllenge as mentioned by Kevin in #1143 (comment)

@tanwarsh tanwarsh mentioned this pull request Nov 18, 2024
@tanwarsh
Copy link
Collaborator Author

@teoparvanov @vrancurel I can still see pipelines and code related to interactive API. Will this be removed?
These 3 pipelines are failing as these interactive api code is using python native API.
eg code in openfl/openfl/interface/interactive_api/*

@teoparvanov
Copy link
Collaborator

@teoparvanov @vrancurel I can still see pipelines and code related to interactive API. Will this be removed? These 3 pipelines are failing as these interactive api code is using python native API. eg code in openfl/openfl/interface/interactive_api/*

Hi @tanwarsh, thanks for refreshing the PR. Could you please remove the failing Interactive API examples from the CI also?

@tanwarsh
Copy link
Collaborator Author

@teoparvanov @vrancurel I can still see pipelines and code related to interactive API. Will this be removed? These 3 pipelines are failing as these interactive api code is using python native API. eg code in openfl/openfl/interface/interactive_api/*

Hi @tanwarsh, thanks for refreshing the PR. Could you please remove the failing Interactive API examples from the CI also?

I have removed the dependency on python native API in openfl/openfl/interface/interactive_api.

@teoparvanov teoparvanov changed the title Deprecate Python Native API Removing the Python Native API Nov 18, 2024
@teoparvanov
Copy link
Collaborator

teoparvanov commented Nov 18, 2024

Thanks @tanwarsh ! Let's freeze this PR for the time of the 1.7 release (we now have a good understanding of the "blast radius" of removing the Python Native API).

As discussed offline, the next step is to produce a new, more conservative PR where you would:

  • mark the Python Native API as deprecated in all docs
  • move the tutorials based on this API under deprecated/native_api

@tanwarsh
Copy link
Collaborator Author

Closing the PR as this will be merged later. Will create another PR to deprecate Python Native API.

@tanwarsh tanwarsh closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants