Bump Python version to 3.9 - 3.11 #1189

tanwarsh · 2024-12-04T06:33:38Z

Changes required to remove support for python version 3.8 and below.

the support will be extended to python 3.12 post tensorflow #1204 and keras update #1174.

MasterSkepticista

Should we set 3.10 through 3.12 (inclusive) as the range? We will already be supporting a python release from 2 years ago with 3.10.

.github/workflows/docker-bench-security.yml

.github/workflows/task_runner_e2e.yml

docs/get_started/examples/interactive_tensorflow_mnist.rst

README.md

docs/developer_guide/running_the_federation.notebook.rst

Signed-off-by: yes <[email protected]>

theakshaypant · 2024-12-05T04:13:30Z

@tanwarsh Can we also run the TaskRunner (Eden Compression) and Workflow Interface Tests once the latest setup.py changes have been pulled into this branch.

Signed-off-by: yes <[email protected]>

.github/workflows/pytest_coverage.yml

Signed-off-by: yes <[email protected]>

.github/workflows/windows.yml

Signed-off-by: yes <[email protected]>

tanwarsh · 2024-12-05T11:29:10Z

@MasterSkepticista @teoparvanov,

We have a deadlock situation here. TensorFlow 2.13 is not supported by Python 3.12, and we have PR #1174 which updates Keras and TensorFlow version to latest. However, we cannot merge it before removing support for Python versions < 3.9, as they are not supported by these latest versions.

My suggestion is to first update the Python version till 3.11, then merge the other PR, and finally add support for Python 3.12.

MasterSkepticista · 2024-12-05T11:42:31Z

@MasterSkepticista @teoparvanov,

We have a deadlock situation here. TensorFlow 2.13 is not supported by Python 3.12, and we have PR #1174 which updates Keras and TensorFlow version to latest. However, we cannot merge it before removing support for Python versions < 3.9, as they are not supported by these latest versions.

My suggestion is to first update the Python version till 3.11, then merge the other PR, and finally add support for Python 3.12.

Please bump 2.13 to 2.14 or 2.15.

Signed-off-by: yes <[email protected]>

…Dec-24

Signed-off-by: yes <[email protected]>

…Dec-24

setup.py

Signed-off-by: yes <[email protected]>

MasterSkepticista · 2024-12-10T07:45:06Z

@tanwarsh It is OK to keep the versions 3.9 thru 3.11

3.12 requires bumping tensorflow>=2.16, and we are not ready for keras>=3 transition until workspaces are updated. Numpy issue is related to the fact that the test loads numpy>2.0 library, while a subprocess tries to downgrade to 1.x as part of workspace creation.

To resolve, try switching to torch_cnn_mnist in the python test script. I also think the test itself silently breaks, looking at previous passing logs. That can be a follow up PR to this.

Edit: To fix the eden_compression CI below, set the FQDN to localhost in the workflow file. Refer to other CI workflow files for reference.

Signed-off-by: yes <[email protected]>

tests/github/pki_wrong_cn.py

* removed python version <= 3.8 Signed-off-by: yes <[email protected]> * changes as per comments Signed-off-by: yes <[email protected]> * revert changes Signed-off-by: yes <[email protected]> * doc updated Signed-off-by: yes <[email protected]> * python version updated to 3.10 to 3.12 Signed-off-by: yes <[email protected]> * python version updated to 3.10 to 3.12 Signed-off-by: yes <[email protected]> * dummy commit Signed-off-by: yes <[email protected]> * dummy commit Signed-off-by: yes <[email protected]> * version changes Signed-off-by: yes <[email protected]> * changed version t0 3.10 Signed-off-by: yes <[email protected]> * fixed typo Signed-off-by: yes <[email protected]> * bump tensorflow to 2.14 Signed-off-by: yes <[email protected]> * bump tensorflow to 2.15 Signed-off-by: yes <[email protected]> * revert tensorflo version and removed python version 3.12 Signed-off-by: yes <[email protected]> * revert tensorflo version and removed python version 3.12 Signed-off-by: yes <[email protected]> * removed astor Signed-off-by: yes <[email protected]> * added nbformat lib Signed-off-by: yes <[email protected]> * formatting fix Signed-off-by: yes <[email protected]> * numpy version fix Signed-off-by: yes <[email protected]> * numpy version fix Signed-off-by: yes <[email protected]> * revert python version back to 3.9 Signed-off-by: yes <[email protected]> * removed astor Signed-off-by: yes <[email protected]> * numpy version change Signed-off-by: yes <[email protected]> * numpy version change Signed-off-by: yes <[email protected]> * numpy version change Signed-off-by: yes <[email protected]> * switch to torch_cnn_mnist Signed-off-by: yes <[email protected]> --------- Signed-off-by: yes <[email protected]>

removed python version <= 3.8

20152c9

Signed-off-by: yes <[email protected]>

MasterSkepticista approved these changes Dec 4, 2024

View reviewed changes

MasterSkepticista changed the title ~~WIP: Remove support for Python 3.8.~~ WIP: Bump Python to 3.9 Dec 4, 2024

teoparvanov reviewed Dec 4, 2024

View reviewed changes

docs/developer_guide/running_the_federation.notebook.rst Outdated Show resolved Hide resolved

tanwarsh added 3 commits December 4, 2024 07:44

changes as per comments

73643ed

Signed-off-by: yes <[email protected]>

revert changes

13a36ea

Signed-off-by: yes <[email protected]>

doc updated

28d8ea5

Signed-off-by: yes <[email protected]>

tanwarsh changed the title ~~WIP: Bump Python to 3.9~~ Bump Python version to 3.9 Dec 4, 2024

tanwarsh and others added 3 commits December 5, 2024 10:46

Merge branch 'develop' into 4-Dec-24

bf7c799

python version updated to 3.10 to 3.12

8932d4c

Signed-off-by: yes <[email protected]>

python version updated to 3.10 to 3.12

e0dac41

Signed-off-by: yes <[email protected]>

tanwarsh added workflow_interface eden_compression labels Dec 5, 2024

tanwarsh added 2 commits December 4, 2024 21:32

dummy commit

e310ea1

Signed-off-by: yes <[email protected]>

dummy commit

2657834

Signed-off-by: yes <[email protected]>

tanwarsh mentioned this pull request Dec 5, 2024

Updated Keras and TensorFlow Task Runner and related workspaces. #1174

Merged

tanwarsh changed the title ~~Bump Python version to 3.9~~ Bump Python version to 3.10 - 3.12 Dec 5, 2024

rajithkrishnegowda reviewed Dec 5, 2024

View reviewed changes

.github/workflows/pytest_coverage.yml Outdated Show resolved Hide resolved

tanwarsh added 2 commits December 4, 2024 21:45

version changes

d3cc37e

Signed-off-by: yes <[email protected]>

changed version t0 3.10

f9dc843

Signed-off-by: yes <[email protected]>

theakshaypant approved these changes Dec 5, 2024

View reviewed changes

.github/workflows/windows.yml Outdated Show resolved Hide resolved

fixed typo

b7b47df

Signed-off-by: yes <[email protected]>

tanwarsh and others added 5 commits December 5, 2024 04:02

bump tensorflow to 2.14

6da85d3

Signed-off-by: yes <[email protected]>

Merge branch 'develop' into 4-Dec-24

d82ad49

bump tensorflow to 2.15

9ad569a

Signed-off-by: yes <[email protected]>

Merge branch '4-Dec-24' of https://github.com/tanwarsh/openfl into 4-…

7421ca5

…Dec-24

Merge branch 'develop' into 4-Dec-24

960f567

tanwarsh and others added 5 commits December 5, 2024 21:03

revert tensorflo version and removed python version 3.12

7aef2dc

Signed-off-by: yes <[email protected]>

revert tensorflo version and removed python version 3.12

aab9ff0

Signed-off-by: yes <[email protected]>

Merge branch 'develop' into 4-Dec-24

d29530c

removed astor

3010b30

Signed-off-by: yes <[email protected]>

Merge branch '4-Dec-24' of https://github.com/tanwarsh/openfl into 4-…

ce7676b

…Dec-24

MasterSkepticista reviewed Dec 6, 2024

View reviewed changes

setup.py Outdated Show resolved Hide resolved

tanwarsh and others added 9 commits December 9, 2024 10:48

Merge branch 'develop' into 4-Dec-24

8c2b8ff

added nbformat lib

423ab4d

Signed-off-by: yes <[email protected]>

formatting fix

c35e577

Signed-off-by: yes <[email protected]>

numpy version fix

9196cf8

Signed-off-by: yes <[email protected]>

numpy version fix

27ccb2f

Signed-off-by: yes <[email protected]>

revert python version back to 3.9

34308e6

Signed-off-by: yes <[email protected]>

removed astor

c9aa62e

Signed-off-by: yes <[email protected]>

Merge branch 'develop' into 4-Dec-24

bf0226a

numpy version change

b15835d

Signed-off-by: yes <[email protected]>

tanwarsh changed the title ~~Bump Python version to 3.10 - 3.12~~ WIP:Bump Python version to 3.10 - 3.12 Dec 10, 2024

tanwarsh added 2 commits December 9, 2024 22:02

numpy version change

efc5571

Signed-off-by: yes <[email protected]>

numpy version change

fbc1917

Signed-off-by: yes <[email protected]>

Merge branch 'develop' into 4-Dec-24

4e6f76f

tanwarsh changed the title ~~WIP:Bump Python version to 3.10 - 3.12~~ WIP:Bump Python version to 3.9 - 3.11 Dec 11, 2024

switch to torch_cnn_mnist

0ee4b80

Signed-off-by: yes <[email protected]>

tanwarsh changed the title ~~WIP:Bump Python version to 3.9 - 3.11~~ Bump Python version to 3.9 - 3.11 Dec 11, 2024

rahulga1 approved these changes Dec 11, 2024

View reviewed changes

theakshaypant approved these changes Dec 11, 2024

View reviewed changes

rajithkrishnegowda approved these changes Dec 11, 2024

View reviewed changes

payalcha reviewed Dec 11, 2024

View reviewed changes

tests/github/pki_wrong_cn.py Show resolved Hide resolved

noopurintel approved these changes Dec 11, 2024

View reviewed changes

tanwarsh merged commit 7e742dd into securefederatedai:develop Dec 11, 2024
25 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Python version to 3.9 - 3.11 #1189

Bump Python version to 3.9 - 3.11 #1189

tanwarsh commented Dec 4, 2024 •

edited

Loading

MasterSkepticista left a comment

theakshaypant commented Dec 5, 2024

tanwarsh commented Dec 5, 2024

MasterSkepticista commented Dec 5, 2024

MasterSkepticista commented Dec 10, 2024 •

edited

Loading

Bump Python version to 3.9 - 3.11 #1189

Bump Python version to 3.9 - 3.11 #1189

Conversation

tanwarsh commented Dec 4, 2024 • edited Loading

MasterSkepticista left a comment

Choose a reason for hiding this comment

theakshaypant commented Dec 5, 2024

tanwarsh commented Dec 5, 2024

MasterSkepticista commented Dec 5, 2024

MasterSkepticista commented Dec 10, 2024 • edited Loading

tanwarsh commented Dec 4, 2024 •

edited

Loading

MasterSkepticista commented Dec 10, 2024 •

edited

Loading