-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Pipelines to use Trusted Artifact #197
Conversation
I only made the changes for logsigner. I plan on doing the other two components after we get an initial run here. |
/ok-to-test |
15f69b6
to
603b95f
Compare
603b95f
to
792c362
Compare
There are a couple of things left here to make the EC validation pass.
With a modified policy config that uses the latest policy rules, and a modified data source for the metadata:
code: cve.cve_blockers
msg: Found 3 CVE vulnerabilities of high security level That is unrelated. It appears to be the common issue where a CVE has been patched in an RPM, but the parent image has not picked it up yet. (The workaround is to run I'm hoping the two issues above will be addressed by tomorrow. |
/retest |
All set. The only violation left is the CVE one from my previous comment. I'll go ahead and update this PR to also move the other Pipelines to use Trusted Artifacts. |
52225ce
to
7b059e8
Compare
The redis Pipeline needs this fix: konflux-ci/build-definitions#1043 |
60f621f
to
ddb8763
Compare
Pulled in the changes from #191 to address the CVE issues. |
Moving this out of draft as I believe all the issues I noticed have been addressed. |
b65dc94
to
43b72ed
Compare
@lcarva, @lance what needs to be done to get this merged? I did testing on my private Konflux namespace and it seems that this PR also fixes the non-working unit tests (see https://redhat-internal.slack.com/archives/C05G8TKPN7P/p1717009207481019) |
Given the churn on the files I modified, this PR needs to be rebased quite often. If you guys are happy with the approach from this PR, then I'm happy to rebase it one more time. 😄 |
If you don't mind a rebase, that would be great. We do have someone (currently on PTO) assigned to handle this task across all of our repos that run unit tests, but having this as a working and merged example would be helpful! 🙇 |
With support for custom Tasks, there is no longer a requirement that all Tasks must come from a Tekton Bundle. Signed-off-by: Luiz Carvalho <[email protected]>
43b72ed
to
09fa2ae
Compare
This commit changes the push and pull-request Pipelines for the various components to use Trusted Artifacts stored in the OCI registry. Signed-off-by: Luiz Carvalho <[email protected]>
09fa2ae
to
3270bce
Compare
@lance, all green now 😎 PTAL |
@lcarva thanks for this! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lance, lcarva The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit changes the push and pull-request Pipelines for the various components to use Trusted Artifacts stored in the OCI registry.
It also modifies the go-unit-test Task so it can be used via the Pipeline as Code resolver[1] removing the need to create a Tekton bundle for it.
[1] https://docs.openshift.com/pipelines/1.11/pac/using-pac-resolver.html
Checklist