Add support for Spack target architecture - Wave CLI #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
marcodelapierre
requested review from
pditommaso
and removed request for
pditommaso
|
@pditommaso will add unit tests on Monday, and then open for review |
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
|
@pditommaso CI failure is due to requirement of Libseqera PR seqeralabs/libseqera#11. Locally the builds and tests succeed. I suggest to first merge the Libseqera one, then come back here. |
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
|
Closing as not planned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
spackTargetattribute within Wave CLI.It comes in conjunction with corresponding PRs for:
To do:
spackTargetin AppspackTargetplatformandspackTarget(same as NF)